Fix a few compile errors due to config#105
Merged
bigbrett merged 3 commits intowolfSSL:mainfrom Apr 27, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes compile errors in wolfHSM-examples related to crypto request creation and SHA256 configuration.
- Updated the crypto request initialization to use _createCryptoRequestWithSubtype.
- Guarded the SHA256 flags initialization with a conditional compile check for WOLFSSL_HASH_FLAGS.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a few compile errors related to configuration in the wolfHSM-examples project.
- In the keystore server code, key output data is now only provided on non-error responses, and the overall response size calculation has been corrected.
- In the crypto client code, the generic crypto request header is now routed through _createCryptoRequestWithSubtype, and SHA256 flags are only set when WOLFSSL_HASH_FLAGS is defined.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/wh_server_keystore.c | Adjusts key output based on response code and updates the overall output size. |
| src/wh_client_crypto.c | Routes crypto request creation via _createCryptoRequestWithSubtype and fixes SHA256 flag handling. |
bigbrett
approved these changes
Apr 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When building wolfHSM-examples, a couple of config errors were found: